test: add isolated response test for iframes #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
changed the title
kettanaito
commented
Jul 12, 2024
| <script> | ||
| const { worker, http } = window.parent.msw | ||
|
|
||
| function isolatedResolver(resolver) { |
There was a problem hiding this comment.
@yannbf, hi 👋 Let's try using this utility in the Storybook add-on and see if it provides us with the context isolation when rendering multiple stories on the same page (in iframes). I hope it does!
The important part here is so this utility runs in the iframe's context, not in the parent context.
Released: v2.3.2 🎉This has been released in v2.3.2! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an automated test for the isolated response scenario when using multiple iframes on the page.
How does this work?
Each iframe becomes the outgoing request's
referrer. If the iframe provides a check in the request handlers to ignore a matching request if it has areferrerdifferent from the current iframe'slocation.href, it will allow two iframes to receive different responses to the same request.