fix: support typescript@5.5 (deprecate v4.7) #2190
Conversation
.github/workflows/compat.yml
Outdated
| @@ -52,7 +52,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ts: ['4.7', '4.8', '4.9', '5.0', '5.1', '5.2', '5.3', '5.4'] | |||
| ts: ['4.7', '4.8', '4.9', '5.0', '5.1', '5.2', '5.3', '5.4', '5.5'] | |||
There was a problem hiding this comment.
As a rule of thumb, adding a new version to the matrix means dropping the left-most one (4.7). Let me check if 4.7 is EOL...
Yeah, 4.7 is EOL now. @KaiSpencer, could you please drop 4.7 from the matrix? Thanks!
test/typings/tsconfig.5.5.json
Outdated
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "extends": "./tsconfig.4.7.json", | |||
There was a problem hiding this comment.
Once we drop 4.7, we need to adjust the name of this base config. Let's see if it's specific to 4.7 in any way. Maybe it's better off as tsconfig.base.json instead.
|
Hey @kettanaito, Thanks for the review. I have updated the tsconfig files to all inherit from the typings I see we also don't have a file for 4.9, yet it is in the matrix. So I have added this file too. |
kettanaito
changed the title
|
I treat this as a fix because TS 4.7 is EOL, nobody should be using it. If they are, it doesn't mean MSW will break, just means we won't address any type issues on that version going forward. |
kettanaito
changed the title
Released: v2.3.2 🎉This has been released in v2.3.2! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Build and tests pass locally for me 👌