Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feature "new URL()" in the redundant query params warning #2102

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

psjostrom
Copy link
Contributor

I noticed that the warning for using query parameters in request handler URL was using the MSW 1 syntax, so I updated it to align with MSW 2 syntax.

@kettanaito kettanaito changed the title fix: align query param warning with msw 2 fix: feature "new URL()" in the redundant query params warning Mar 20, 2024
@kettanaito
Copy link
Member

A great find! Thank you, @psjostrom. Left one suggestions to the phrasing, would love to hear your opinion on it.

Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic!

@kettanaito
Copy link
Member

Welcome to contributors, @psjostrom 👏

@kettanaito kettanaito merged commit 9af301a into mswjs:main Mar 21, 2024
11 checks passed
@kettanaito
Copy link
Member

Released: v2.2.10 🎉

This has been released in v2.2.10!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants