feat: migrate to node 16.14.0 (lts) #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kettanaito
commented
Mar 1, 2022
•
kettanaito
commented
- Closes What versions of node do we want to support? #217
- Updates to Node.js 16.14.0 as the officially supported version.
- Updates any related dependencies.
kettanaito
force-pushed
the
chore/node-16
branch
from
c4c33e6 to
bf0ade6
Compare
kettanaito
commented
Mar 1, 2022
| this.observer.emit('response', isomorphicRequest, isomorphicResponse) | ||
| // Execute the resolver Promise like a side-effect. | ||
| // Node.js 16 forces "ClientRequest.end" to be synchronous and return "this". | ||
| until(async () => this.resolver(isomorphicRequest, this.response)).then( |
There was a problem hiding this comment.
Resolver execution is a side-effect right now. This needs to be tested.
There was a problem hiding this comment.
Automated tests report no issues. Response handling logic is asynchronous by design. I think when Node 16 forced end to return this they accounted for it. As in: return the next (potentially unresolved) state of ClientRequest.
|
The |
kettanaito
force-pushed
the
chore/node-16
branch
2 times, most recently
from
b55e201 to
0de3e6d
Compare
|
Need to publish 7d8f6bd first. |
kettanaito
force-pushed
the
chore/node-16
branch
from
0de3e6d to
cf678f5
Compare
kettanaito
force-pushed
the
chore/node-16
branch
from
cf678f5 to
8074fcb
Compare
|
🎉 This PR is included in version 0.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.