-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6168 customised reports satisfaction rate per program #6428
base: develop
Are you sure you want to change the base?
6168 customised reports satisfaction rate per program #6428
Conversation
@@ -0,0 +1,52 @@ | |||
import React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole file change was just a rename. This one only gets the Patient programs through documents
setPeriod(period); | ||
handleChange(path, period.id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have to refactor this in other report issue to also return the start/end date to correctly filter out stocktake/prescriptions by start/end time
import { PeriodFragment } from '@openmsupply-client/requisitions'; | ||
|
||
export const usePeriodList = (programId?: string, enabled?: boolean) => { | ||
const { api, storeId } = useProgramsGraphQL(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reusing the programs graphQL since they're kinda grouped together...
@@ -22,7 +26,7 @@ pub fn programs( | |||
let user = validate_auth( | |||
ctx, | |||
&ResourceAccessRequest { | |||
resource: Resource::QueryProgram, | |||
resource: Resource::QueryMasterList, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used for both Patient & Requisition programs... and doesn't make sense to use QueryProgram permission when that is a Patient Program specific permission... though it has a lot of other checks... maybe should have just created a dup with query masterlist permission? π
Bundle size differenceComparing this PR to
|
Fixes #6168
π©π»βπ» What does this PR do?
Review alongside https://github.com/msupply-foundation/open-msupply-reports/pull/140. Both are needed to close Satisfaction Report issue. This PR:
ProgramSearch
->PatientProgramSearch
π§ͺ Testing
π Documentation
1.
2.