6272 move status change to footer #6276
Conversation
github-actions
bot
added
feature: vaccine card
Team: Kororā 🐧
Bundle size differenceComparing this PR to
|
| @@ -46,7 +46,7 @@ export const SplitButton = <T,>({ | |||
| <ButtonGroup color={color} variant="outlined" aria-label={ariaLabel}> | |||
| <ButtonWithIcon | |||
| color={color} | |||
| disabled={isDisabled} | |||
| disabled={isDisabled || selectedOption.isDisabled} | |||
There was a problem hiding this comment.
Hopefully we are okay with the change?
There was a problem hiding this comment.
It does look a little funky!
Does this essentially ensure the currently selected option is greyed out if that's the current status anyway?
There was a problem hiding this comment.
Yeah basically - already visited, so shouldn't be able to mark as visited, but we still want that to be the default option of the button. If they want to change to cancelled or back to pending, can do by selected the dropdown
Before, the only option was to disable the entire button
There was a problem hiding this comment.
I just noticed them radiuses:
Was it already cursed to be square before this PR?
There was a problem hiding this comment.
Yeah - Mariya's got that in some new designs, I don't think there is a specific issue for it yet though... unless easy to include in your button PR @aimee-mcneil-melville?:
There was a problem hiding this comment.
Yeah it sounds straight forward - I'll take a look :)
There was a problem hiding this comment.
I've updated the split button to have the rounded corners on the right hand side - I'm not set up for encounters so haven't tested in this area with the disabled split yet
| @@ -81,11 +81,15 @@ const useSaveWithStatus = ( | |||
| }; | |||
| }; | |||
|
|
|||
| const useSaveWithStatusChangeModal = ( | |||
| const useSaveWithStatusChange = ( | |||
There was a problem hiding this comment.
just renaming as I'm now using both in and outside of the modal
| @@ -133,7 +142,7 @@ export const Footer: FC<FooterProps> = ({ | |||
| gap={2} | |||
| > | |||
| <Typography sx={{ fontSize: 18, fontWeight: 700 }}> | |||
| Document Edit History | |||
| {t('label.document-edit-history')} | |||
There was a problem hiding this comment.
side quest - missed translation from ages ago!
| @@ -46,7 +46,7 @@ export const SplitButton = <T,>({ | |||
| <ButtonGroup color={color} variant="outlined" aria-label={ariaLabel}> | |||
| <ButtonWithIcon | |||
| color={color} | |||
| disabled={isDisabled} | |||
| disabled={isDisabled || selectedOption.isDisabled} | |||
There was a problem hiding this comment.
It does look a little funky!
Does this essentially ensure the currently selected option is greyed out if that's the current status anyway?
Fixes #6272
👩🏻💻 What does this PR do?
Make status change/delete workflows of encounters match those of other features.
Removes status change and delete from toolbar.
Adds delete button to side panel, and status change to footer:
Pre-requisite to hooking into status change logic within vax card.
💌 Any notes for the reviewer?
🧪 Testing
Mark as Visitedby default📃 Documentation
1.
2.