-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uuid v7 instead of v4 #4052
Conversation
Using uuid v7 improves write and improves read performance for sequential reads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't most of our UUIDs generated from the frontend?
Does this exist for typescript? I assume it does?
ah yes you are right, would have to do it on the frontend |
Haha merged 3 days ago: uuidjs/uuid#681 but last release was 9 month ago... |
I had a look at the uuidv7 nodejs package https://www.npmjs.com/package/uuidv7. Also had a brief browse through the repo and it looks good to me... |
Bundle size differenceComparing this PR to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me...
Using uuid v7 improves write and improves read performance for sequential reads.
Fixes #4038