Add the syncServerUrl to bugsnag context #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the syncURL to bugsnag context, and a breadcrumb for BLE Server Restarts.
None of these are particularly important, but would be useful to at least have a URL to traceback when an error is logged.
Mainly wanted to do something to ensure it's working.
We could log a lot more errors (Bluetooth connection issues for example) maybe in future we have a debug setting to enable sending all these errors to bugsnag? We probably don't want every URL sync issue and every bluetooth connectivity issue sent, but would be helpful to be able to turn that on somehow. See also: #21 Better Bugsnag Breadcrumbing
Also: adds a .gitignore for build files we don't want to commit