Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4164 RN cant reload old state #4255

Merged
merged 1 commit into from
Jul 19, 2021
Merged

#4164 RN cant reload old state #4255

merged 1 commit into from
Jul 19, 2021

Conversation

josh-griffin
Copy link
Contributor

Fixes #4164 - maybe

Change Summary

The bugsnag error has a link to this github comment software-mansion/react-native-screens#17 (comment) where we find out our MainActivity is configured incorrectly!

Testing

  • The app still runs..?

Related areas to think about

  • I can't reproduce the error, but the people said to do this so..

kat-ms
kat-ms approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@kat-ms kat-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds promising 🤞 - a lot of the crashes I'd seen on BugSnag did seem to have something about MainActivity starting back up from the background...

@josh-griffin josh-griffin merged commit 04babff into develop Jul 19, 2021
@josh-griffin josh-griffin deleted the #4164-rn-cant-reload-old-state branch July 19, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kat-ms kat-ms kat-ms approved these changes

@mark-prins mark-prins Awaiting requested review from mark-prins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josh-griffin @kat-ms