Skip to content

Commit

Permalink
add processor.max_cstate=0 to intel cpu cmdline (sonic-net#16339)
Browse files Browse the repository at this point in the history
Why I did it
This is a fix for PR [kernel] Change grub cmdline to set c-states to 0 for "Intel" CPUs by shlomibitton · Pull Request sonic-net#6051 · sonic-net/sonic-buildimage (github.com)

The original PR will disable intel idle driver but it cannot limit the max c-state to 1 due to system will fall back to acpi idle driver.

Currently intel_idle.max_cstate=0 is already present, which will disable intel idle driver. With the added option, common idle driver will be disabled as well, so there will not be idle management. This is to prevent a bug that can be triggered by idle instruction on intel platform.

How I did it
Add the option to installer file beside intel_idle.max_cstate=0
  • Loading branch information
Xichen96 authored and mssonicbld committed Sep 3, 2023
1 parent 7b89066 commit 986bfe3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion installer/default_platform.conf
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ bootloader_menu_config()
echo "Switch CPU vendor is: $CPUVENDOR"
if echo "$CPUVENDOR" | grep -i 'Intel' >/dev/null 2>&1; then
echo "Switch CPU cstates are: disabled"
CSTATES="intel_idle.max_cstate=0"
CSTATES="processor.max_cstate=1 intel_idle.max_cstate=0"
else
CSTATES=""
fi
Expand Down

0 comments on commit 986bfe3

Please sign in to comment.