This repository has been archived by the owner on May 29, 2022. It is now read-only.
Add team ID and await build parameters #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskelton
reviewed
Sep 18, 2020
index.js
Outdated
Comment on lines
38
to
42
| const awaitBuild = core.getInput("await-build") | ||
|
|
||
| if(awaitBuild && data.deployments[0].state !== "READY"){ | ||
| throw Error("Deployment not yet ready") | ||
| } |
There was a problem hiding this comment.
This logic could be moved to a helper function to be used in both places.
There was a problem hiding this comment.
Updated in ec5b21c
Thank you for the initial work, this action has been really useful!
There was a problem hiding this comment.
Glad to hear it has been useful! There is nothing quite like the feeling of building an open source projects that other people find useful!
Co-authored-by: Mark Skelton <mdskelton99@gmail.com>
Co-authored-by: Mark Skelton <mdskelton99@gmail.com>
|
I just published version 1.2.0 and updated the v1 tag so your changes are now live and ready to use! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
team-idparameter for deployments owned by a team (see Accessing Resources Owned by a Team)await-buildparameter to check for the build to be succesfully built (see Deployment Response Parameters)