This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
Add support for sub routers with parameterized routes #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when using a sub router on a parameterized route like
`app.use('/foo/:param', router)`, `findRouteName` would not correctly
resolve the route parameter for the parent route. This happened because
`req.baseUrl` contained the url with the value, not the parameter. To
solve this, this PR adds code to translate from the url with the value,
back to the parameterized version (i.e. `/foo/value -> /foo/:param`).
|
Quick note - it looks like the tests failed in node 4, but that also occurs when running them on master without these changes due to a major version change of debug, a dependency of mocha 1.6.0 that's installed with |
|
Hi @msiebuhr, any update on merging this? We've been running this for quite some time with no issues. |
|
But tests on node-4 fails. Since it's probably time to ditch it anyway, would you mind fixing the config for travisci up, so we can get rid of the error? |
|
Agreed since node 4 has reached EOL. I'll update the config 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when using a sub router on a parameterized route like
app.use('/foo/:param', router),findRouteNamewould not correctlyresolve the route parameter for the parent route. This happened because
req.baseUrlcontained the url with the value, not the parameter. Tosolve this, this PR adds code to translate from the url with the value,
back to the parameterized version (i.e.
/foo/value -> /foo/:param).