This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
Add express middleware support for sub-routers #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit pre-pends req.baseUrl to the default StatsD key for the express middleware when timeByUrl is true. This allows express "mini-applications" and makes sure that the url "/subrouter/foo" and "/foo" get distinct StatsD keys when "/subrouter" is an express "mini-application" Changes: - Add req.baseUrl to express middleware StatsD key. - Add express tests.
|
Good catch. And very nice with the tests too! |
msiebuhr
added a commit
that referenced
this pull request
Mar 17, 2016
Add express middleware support for sub-routers
|
Published in v0.2.2 |
|
Thanks 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pre-pends
req.baseUrlto the default StatsD key for the express middleware whentimeByUrlis true. This allows express "mini-applications" and makes sure that the url "/subrouter/foo" and"/foo" get distinct StatsD keys when "/subrouter" is an express "mini-application".
Changes:
Express documentation: http://expressjs.com/en/4x/api.html#router