Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack double and float more size efficient #1018

Merged
merged 7 commits into from
Jun 13, 2022
Merged

pack double and float more size efficient #1018

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6f0683b
pack double and float more size efficient
GeorgFritze May 13, 2022
68acf21
pack double and float in a more size efficient way
GeorgFritze Jun 2, 2022
3b405fc
Merge branch 'msgpack:cpp_master' into cpp_master
GeorgFritze Jun 2, 2022
d5c837b
style changes
GeorgFritze Jun 3, 2022
d59e1d7
update msgpack_basic test for compact double packaging
GeorgFritze Jun 7, 2022
05de839
fix bug in pack_float and pack_double
GeorgFritze Jun 13, 2022
33ff3a4
fix undefined bahaviour in msgpack_basic tests
GeorgFritze Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions include/msgpack/v1/pack.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,6 +1138,18 @@ inline packer<Stream>& packer<Stream>::pack_unsigned_long_long(unsigned long lon
template <typename Stream>
inline packer<Stream>& packer<Stream>::pack_float(float d)
{
if (d == d) { // check for nan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (d == d) { // check for nan
if(d == d) { // check for nan

// compare d to limits::max() to avoid undefined behaviour
if (d >= 0 && d <= std::numeric_limits<uint64_t>::max() && d == uint64_t(d)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (d >= 0 && d <= std::numeric_limits<uint64_t>::max() && d == uint64_t(d)) {
if(d >= 0 && d <= std::numeric_limits<uint64_t>::max() && d == uint64_t(d)) {

pack_imp_uint64(uint64_t(d));
return *this;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please erase empty line above.

} else if (d >= std::numeric_limits<int64_t>::min() && d == int64_t(d)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} else if (d >= std::numeric_limits<int64_t>::min() && d == int64_t(d)) {
} else if(d >= std::numeric_limits<int64_t>::min() && d == int64_t(d)) {

pack_imp_int64(int64_t(d));
return *this;
}
}

union { float f; uint32_t i; } mem;
mem.f = d;
char buf[5];
Expand All @@ -1149,6 +1161,18 @@ inline packer<Stream>& packer<Stream>::pack_float(float d)
template <typename Stream>
inline packer<Stream>& packer<Stream>::pack_double(double d)
{
if (d == d) { // check for nan
// compare d to limits::max() to avoid undefined behaviour
if (d >= 0 && d <= std::numeric_limits<uint64_t>::max() && d == uint64_t(d)) {
pack_imp_uint64(uint64_t(d));
return *this;

} else if (d >= std::numeric_limits<int64_t>::min() && d == int64_t(d)) {
pack_imp_int64(int64_t(d));
return *this;
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the same fix as float.

union { double f; uint64_t i; } mem;
mem.f = d;
char buf[9];
Expand Down