Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade xxhash to use Nan>=2.0, add unit test #10

Closed
wants to merge 1 commit into from
Closed

Upgrade xxhash to use Nan>=2.0, add unit test #10

wants to merge 1 commit into from

Conversation

chaosgame
Copy link
Contributor

Upgrading to Nan 2.0 is required for running xxhash with io.js 3.x and higher.

@chaosgame
Copy link
Contributor Author

Addresses #9.

@asilvas
Copy link

asilvas commented Sep 8, 2015

+1 bump

@ChALkeR
Copy link

ChALkeR commented Sep 10, 2015

Adding to the list: nodejs/node#2798.

@asilvas asilvas mentioned this pull request Sep 11, 2015
Closed
@mscdex
Copy link
Owner

mscdex commented Sep 13, 2015

Landed in c5fb41e. Thanks!

@mscdex mscdex closed this Sep 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaosgame @asilvas @ChALkeR @mscdex