Support file input as optional

mscdex · Jan 8, 2025 · d835984 · d835984
1 parent 6b3dcf6
commit d835984
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/lib/types/multipart.js b/lib/types/multipart.js
@@ -315,7 +315,7 @@ class Multipart extends Writable {
 
         if (disp.params['filename*'])
           filename = disp.params['filename*'];
-        else if (disp.params.filename)
+        else if (disp.params.filename !== undefined)
           filename = disp.params.filename;
 
         if (filename !== undefined && !preservePath)

diff --git a/test/test-types-multipart.js b/test/test-types-multipart.js
@@ -867,6 +867,32 @@ const tests = [
     ],
     what: 'Empty part'
   },
+    { source: [
+            ['-----------------------------paZqsnEHRufoShdX6fh0lUhXBP4k',
+                'Content-Disposition: form-data; '
+                + 'name="upload_file_0"; filename=""',
+                'Content-Type: application/octet-stream',
+                '',
+                '',
+                '-----------------------------paZqsnEHRufoShdX6fh0lUhXBP4k--',
+            ].join('\r\n')
+        ],
+        boundary: '---------------------------paZqsnEHRufoShdX6fh0lUhXBP4k',
+        expected: [
+            { type: 'file',
+                name: 'upload_file_0',
+                data: new Buffer.from(''),
+                info: {
+                    filename: '',
+                    encoding: '7bit',
+                    mimeType: 'application/octet-stream',
+                },
+                limited: false,
+            }
+        ],
+        events: ['file'],
+        what: 'Optional file'
+    }
 ];
 
 for (const test of tests) {