Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests 2.32.0 Not supported URL scheme http+unix #73

Closed
cartertinney opened this issue May 22, 2024 · 4 comments · Fixed by #72
Closed

Requests 2.32.0 Not supported URL scheme http+unix #73

cartertinney opened this issue May 22, 2024 · 4 comments · Fixed by #72

Comments

@cartertinney
Copy link

cartertinney commented May 22, 2024 •
edited
Loading

Latest security fix for requests has broken requests-unixsocket. It appears they do not plan to fix the breakage, and are suggesting it be the responsibility of consuming libraries.

Will there be a fix coming for this? Or will PRs for fixing it be accepted/released?
@brasse
Copy link

brasse commented May 22, 2024

Would the same fix work here?

docker/docker-py#3257

@cartertinney
Copy link
Author

@brasse Yes, that is my understanding that that would be all that is required.

@crgwbr
Copy link
Collaborator

crgwbr commented May 22, 2024

FYI to all: since this project seems to be abandoned, but its longevity is important to my team, we've forked the project as requests-unixsocket2. It should be a drop in replacement for this package.

We've migrated the fix for this issue there, merged it, and released to PyPI as part of v0.4.0.

@simondeziel simondeziel mentioned this issue May 23, 2024
Merged
@kimfaint kimfaint mentioned this issue May 27, 2024
Closed
@fdelu fdelu mentioned this issue May 29, 2024
Closed
tigarmo added a commit to canonical/craft-application that referenced this issue May 31, 2024
@tigarmo
build(deps): pin requests to <2.32.0
4ddfa3b 
Version 2.32.0 breaks with the "http+unix" protocol used by requests-unixsocket,
which in turn is used by craft-parts. Pin this as a "dev" dependency since the
issue is in craft-parts, and not here.

Ref: msabramo/requests-unixsocket#73
tigarmo added a commit to canonical/craft-application that referenced this issue May 31, 2024
@tigarmo
build(deps): pin requests to <2.32.0
e3f9442 
Version 2.32.0 breaks with the "http+unix" protocol used by requests-unixsocket,
which in turn is used by craft-parts. Pin this as a "dev" dependency since the
issue is in craft-parts, and not here.

Ref: msabramo/requests-unixsocket#73
tigarmo added a commit to canonical/craft-application that referenced this issue May 31, 2024
@tigarmo
build(deps): pin requests to <2.32.0
a39b3cd 
Version 2.32.0 breaks with the "http+unix" protocol used by requests-unixsocket,
which in turn is used by craft-parts. Pin this as a "dev" dependency since the
issue is in craft-parts, and not here.

Ref: msabramo/requests-unixsocket#73
@L3n41c L3n41c mentioned this issue Jun 1, 2024
Merged
4 tasks
arcan1s added a commit to arcan1s/ahriman that referenced this issue Jun 12, 2024
@arcan1s
build: use requests-unixsocket2 fork
42361c3 
Since requests-2.32.0, the http+unix url scheme is brokek, check
msabramo/requests-unixsocket#73 for more
details
arcan1s added a commit to arcan1s/ahriman that referenced this issue Jun 12, 2024
@arcan1s
build: use requests-unixsocket2 fork
e2efe21 
Since requests-2.32.0, the http+unix url scheme is brokek, check
msabramo/requests-unixsocket#73 for more
details
@robin-wayve robin-wayve mentioned this issue Jun 19, 2024
Closed
roypat added a commit to roypat/firecracker that referenced this issue Jul 16, 2024
@roypat
fix: downgrade requests to 2.31.0 in devctr
2ec87f7 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this issue Jul 16, 2024
@roypat
fix: downgrade requests to 2.31.0 in devctr
a186613 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this issue Jul 16, 2024
@roypat
fix: downgrade requests to 2.31.0 in devctr
e042152 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this issue Jul 16, 2024
@roypat
fix: downgrade requests to 2.31.0 in devctr
9db4b84 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this issue Jul 16, 2024
@roypat
fix: downgrade requests to 2.31.0 in devctr
942a6b8 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this issue Jul 16, 2024
@roypat
fix: downgrade requests to 2.31.0 in devctr
343fda8 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this issue Jul 16, 2024
@roypat
fix: downgrade requests to 2.31.0 in devctr
2ed1205 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this issue Jul 16, 2024
@roypat
fix: downgrade requests to 2.31.0 in devctr
f0c8c17 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this issue Jul 16, 2024
@roypat
fix: downgrade requests to 2.31.0 in devctr
54f8a6a 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this issue Jul 16, 2024
@roypat
fix: downgrade requests to 2.31.0 in devctr
2a0c745 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added a commit to roypat/firecracker that referenced this issue Jul 22, 2024
@roypat
fix: downgrade requests to 2.31.0 in devctr
47ab39e 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
zulinx86 pushed a commit to firecracker-microvm/firecracker that referenced this issue Jul 22, 2024
@roypat @zulinx86
fix: downgrade requests to 2.31.0 in devctr
46b96c0 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@gaelgatelement gaelgatelement mentioned this issue Jul 26, 2024
Open
arcan1s added a commit to arcan1s/ahriman that referenced this issue Aug 14, 2024
@arcan1s
build: use requests-unixsocket2 fork
b151615 
Since requests-2.32.0, the http+unix url scheme is brokek, check
msabramo/requests-unixsocket#73 for more
details
ghost pushed a commit to JamesC1305/firecracker that referenced this issue Aug 14, 2024
@roypat @JamesC1305
fix: downgrade requests to 2.31.0 in devctr
5792fdf 
requests 2.32.0 breaks requests-unixsocket, which seems to be abandoned
[1]. So pin it to a version that works.

[1]: msabramo/requests-unixsocket#73

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@erjoalgo erjoalgo mentioned this issue Aug 19, 2024
Merged
PerfectSlayer added a commit to DataDog/dd-trace-java-docker-build that referenced this issue Aug 22, 2024
@PerfectSlayer
fix: Fix unix socket support of autoforward
2c8a9f0 
requests 2.32 introduce behavior break in validating scheme: psf/requests#6707
requests-unixsocket is no more maintained but a fork was put in place to fix the issue: msabramo/requests-unixsocket#73
@PerfectSlayer PerfectSlayer mentioned this issue Aug 22, 2024
Merged
PerfectSlayer added a commit to DataDog/dd-trace-java-docker-build that referenced this issue Aug 22, 2024
@PerfectSlayer
fix: Fix unix socket support of autoforward
c5489e3 
requests 2.32 introduce behavior break in validating scheme: psf/requests#6707
requests-unixsocket is no more maintained but a fork was put in place to fix the issue: msabramo/requests-unixsocket#73
@spencer-tb spencer-tb mentioned this issue Sep 6, 2024
Merged
arcan1s added a commit to arcan1s/ahriman that referenced this issue Sep 30, 2024
@arcan1s
build: use requests-unixsocket2 fork
148ef09 
Since requests-2.32.0, the http+unix url scheme is brokek, check
msabramo/requests-unixsocket#73 for more
details
@pronovic pronovic mentioned this issue Oct 20, 2024
Merged
@webknjaz
Copy link
Collaborator

webknjaz commented Jan 5, 2025

xref #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adapters: fix for requests 2.32.2+ simondeziel/requests-unixsocket
4 participants
@brasse @crgwbr @webknjaz @cartertinney