Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cppStandard from ros version #1292

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Set cppStandard from ros version #1292

merged 1 commit into from
Jun 1, 2024

Conversation

jmblixt3
Copy link

@jmblixt3 jmblixt3 commented May 31, 2024

Create a function that looks up ros version setting and then sets cppStandard variable accordingly ROS1:https://www.ros.org/reps/rep-0003.html
ROS2:https://www.ros.org/reps/rep-2000.html

Fixes:#1288

Create a function that looks up ros version setting and then sets cppStandard variable accordingly
ROS1:https://www.ros.org/reps/rep-0003.html
ROS2:https://www.ros.org/reps/rep-2000.html

Signed-off-by: Jonathan <jmblixt3@gmail.com>
@jmblixt3 jmblixt3 requested a review from a team as a code owner May 31, 2024 21:09
Copy link
Member

@ooeygui ooeygui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the contribution.

@ooeygui ooeygui merged commit a32f83d into ms-iot:master Jun 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants