feat: v-html in notifications to allow markup (#1035) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(inlinenotification): change subtitle to use vhtml to allow markup * feat(toastnotification): toast to use vhtml to allow markup + fix knobs * cv-inline-notification-notes.md add href="#" * cv-toast-notification-notes.md add href="#" * cv-inline-notification-story.js add href="#" * cv-toast-notification-story.js add href="#" Co-authored-by: Jack Mason <jack.mason1@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(inlinenotification): change subtitle to use vhtml to allow markup
feat(toastnotification): toast to use vhtml to allow markup + fix knobs
cv-inline-notification-notes.md add href="#"
cv-toast-notification-notes.md add href="#"
cv-inline-notification-story.js add href="#"
cv-toast-notification-story.js add href="#"
Co-authored-by: Jack Mason jack.mason1@ibm.com
Closes #
{{short description}}
Changelog
{{run "git diff --name-status $(git merge-base head master)" and paste result here}}