Running JShell through Exec task #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @arcesino , this looks good! I'll test it tomorrow I hope. |
arcesino
changed the title
|
@arcesino your PR works like a charm !! Thanks very much for your contributor, I tried to tackle this problem with different approaches and none worked, and testing your solution with a few projects did work ! After merge going to add a fix more stuff and then release a new version with your patch. |
|
@mrsarm glad to contribute! |
mrsarm
added a commit
that referenced
this pull request
Jul 12, 2021
- Remove support to old Gradle versions where it's unlikely Java 9+ is used - Use ~compile~ → implementation (compile is deprecated) - Remove unused and deprecated JCenter repo - Upgrade publishing repo plugin - Remove note about the plugin not working with Java 12+ fixed in #6 - Typo fixes
mrsarm
added a commit
that referenced
this pull request
Jul 15, 2021
…nd typo fixes (#7) Upgrade building conf, README notes and Bump → 1.1.0 - Remove support to old Gradle versions where it's unlikely Java 9+ is used - Use ~compile~ → implementation (compile is deprecated) - Remove unused and deprecated JCenter repo - Upgrade publishing repo plugin - Bump → 1.1.0 - Remove note about the plugin not working with Java 12+ fixed in #6 - Typo fixes - Add trick to overcome autocompletion in the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #1. The approach is simply to make the
"jshell"task of typeExecand configured it so that it runs thejshellcommand with the arguments computed by the"jshellSetup"task. The key fix is to setstandardInput = System.inwhen configuring theExectask which is kind of a known workaround to run interactive command line applications withgradle run.I've tested this with Gradle 7.1 and OpenJDK 11, 14 & 16 and seems to work correctly although the issue with the arrow keys described in #5 and also here gradle/gradle#4982 (comment) are still present.
This also works with the workaround mentioned in #5 of using
rlwrapto make the arrow keys work.