Boolean.parse string values from gradle properties #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey - thanks for your PR, but the line is a bit messy - could you instead create a separate function below Thank you! |
Done! |
|
Awesome, thanks man LGTM! |
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
…#2599) * parse string booleans from gradle properties * Define separate safeExtGetBool function --------- Co-authored-by: Jonas Thuresson <jonas.thuresson@klarna.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The properties
VisionCamera_disableFrameProcessorsandVisionCamera_enableCodeScannerwhen defined is returned as strings byrootProject.ext.get. So when for example settingVisionCamera_enableCodeScanner=falseingradle.properties, the read value of it is the string"false". It is later used in a conditional, butif("false")evaluates totruewhich is not the intended behaviour.Changes
Use
Boolean.parseto parse props that are expected to have a boolean valueTested on
Related issues