Skip to content
This repository has been archived by the owner on Jun 1, 2020. It is now read-only.

Scalafmt version bump from 2.2.2 to 2.3.2 #8

Merged
merged 1 commit into from
Dec 21, 2019
Merged

Scalafmt version bump from 2.2.2 to 2.3.2 #8

merged 1 commit into from
Dec 21, 2019

Conversation

myDisconnect
Copy link
Contributor

No description provided.

@mroth
Copy link
Owner

mroth commented Dec 20, 2019

Huh, does GitHub Actions not run on outside PRs? Let me look into this and report back... (I can run locally manually if not.)

(Btw, for a full production release, we also will need to update the version of scalafmt for the Mac/Linux binaries, which is in .github/workflows/build.yml, currently at line 65. I haven't figured out a way to have one place to set it for both yet.)

@mroth
Copy link
Owner

mroth commented Dec 20, 2019

I pushed a change in f1b2b96 that I believe (hope ) will make the GitHub Actions CI run on PRs as well. If you rebase your branch to that I think we'll see it run?

@mroth
Copy link
Owner

mroth commented Dec 21, 2019

Interesting, on the CI it looks like these are building fine. @myDisconnect should we try to debug why it doesn't build on your machine locally first, or okay to merge this and do a release?

@myDisconnect
Copy link
Contributor Author

Merge it 👍

@mroth
Copy link
Owner

mroth commented Dec 21, 2019

Thanks!

@mroth mroth merged commit c0932c0 into mroth:master Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants