Skip to content

Commit

Permalink
Fix asan.test_main_thread_em_asm_pthread (emscripten-core#21339)
Browse files Browse the repository at this point in the history
Without this change this tests fails to compile with `em++: error:
-pthread + ALLOW_MEMORY_GROWTH may run non-wasm code slowly`.

This test was recently added in emscripten-core#21292 and this wasn't caught
immediately because we don't run the `asan` suite during CI.
  • Loading branch information
sbc100 authored and mrolig5267319 committed Feb 23, 2024
1 parent 7a92b73 commit 216c10b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -1897,6 +1897,8 @@ def test_em_asm_2(self):
'pthread': (['-pthread', '-sPROXY_TO_PTHREAD', '-sEXIT_RUNTIME'],),
})
def test_main_thread_em_asm(self, args):
if args:
self.setup_node_pthreads()
src = read_file(test_file('core/test_em_asm_2.cpp'))
create_file('test.cpp', src.replace('EM_ASM', 'MAIN_THREAD_EM_ASM'))

Expand Down

0 comments on commit 216c10b

Please sign in to comment.