Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PersonModel for non-web logging #48

Merged
merged 2 commits into from
Mar 6, 2016
Merged

Added PersonModel for non-web logging #48

merged 2 commits into from
Mar 6, 2016

Conversation

Atrejoe
Copy link
Contributor

@Atrejoe Atrejoe commented Mar 5, 2016

Obtained user information from the environment

Obtained user information from the environment
@richardversluis
Copy link
Collaborator

This is interesting, but I'm worried this a bit confusing in web-usage when working with threads / tasks, situations where there isn't a HttpContext.Current. You'll get a mix of real users and webserver(s) in Rollbar under the People tab.

It would be perfect if we could detect we're using Rollbar in a desktop application (I think this is your usecase?). A empty HttpContext.Current doesn't mean we aren't using Rollbar in a webapplication.

@Atrejoe
Copy link
Contributor Author

Atrejoe commented Mar 6, 2016

You are right about the possible confusion.
Maybe we could base it in a aptly named configuration switch?
Shall I make a proposal?

On detection of a desktop environment, do you have any suggestions?

On Mar 6, 2016 12:11 PM, Richard Versluis notifications@github.com wrote:

This is interesting, but I'm worried this a bit confusing in web-usage when working with threads / tasks, situations where there isn't a HttpContext.Current. You'll get a mix of real users and webserver(s) in Rollbar under the People tab.

It would be perfect if we could detect we're using Rollbar in a desktop application (I think this is your usecase?). A empty HttpContext.Current doesn't mean we aren't using Rollbar in a webapplication.


Reply to this email directly or view it on GitHub.

@richardversluis
Copy link
Collaborator

Maybe something like this?

http://stackoverflow.com/questions/3179716/how-determine-if-application-is-web-application

HostingEnvironment.IsHosted

@Atrejoe
Copy link
Contributor Author

Atrejoe commented Mar 6, 2016

I added the clause detecting wether the application is in a hosted environment.

The mentioned overhead is already present, as this component already references System.Web.

richardversluis added a commit that referenced this pull request Mar 6, 2016
Added PersonModel for non-web logging
@richardversluis richardversluis merged commit 508ec0f into mroach:master Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants