Upgrade package to use svelte kit packaging with typescript #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relies on onMount instead which only runs in the browser and doesn't require the package user to have vite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jack! :D
Here's a little PR to bring this package up-to-date with the svelte kit package framework with typescript.
This resolves the existing typescript issues and removes the need to write the component types manually.
When building it I found that it was suggesting the removal of any vite-specific code, the browser checks, but then realised we can get away without them anyway due to the use of onMount.
As part of the project upgrade I included the option for using prettier + eslint which did some minor tweaks to the styling (removed trailing commas and some readme formatting?).
The package version was bumped to 2.0 to account for the breaking changes of using sveltekit instead of rollup (which I presume might break some downstream users).
I'm testing this locally with our current sveltekit app to debug any issues but it seems to be working as expected.
Let me know what you think :)