Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependencies and tests #173

Merged
merged 10 commits into from
Dec 3, 2022
Merged

feat: update dependencies and tests #173

merged 10 commits into from
Dec 3, 2022

Conversation

mrmckeb
Copy link
Owner

@mrmckeb mrmckeb commented Nov 21, 2022

This updates dependencies, along with the following smaller changes:

  • Updates the ESLint config to use @typescript-eslint/strict.
  • Fixes test issues from the last PR (commented out).
  • Moves to pnpm.

@mrmckeb mrmckeb force-pushed the mrmckeb/nov22-updates branch from d5e5954 to 3a4698e Compare November 21, 2022 08:49
@mrmckeb mrmckeb force-pushed the mrmckeb/nov22-updates branch from dd42e50 to 5898a0f Compare November 21, 2022 09:01
@mrmckeb mrmckeb requested a review from lianapache November 21, 2022 09:21
codybrouwers
codybrouwers previously approved these changes Nov 22, 2022
Copy link
Collaborator

@lianapache lianapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just have two minor suggestions:

package.json Outdated
"author": "Brody McKee <mrmckeb@hotmail.com>",
"license": "MIT",
"description": "CSS modules support for TypeScript",
"homepage": "https://github.com/mrmckeb/typescript-plugin-css-modules",
"packageManager": "pnpm@7.16.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment on lines 79 to 80
error: Less.RenderError | undefined,
output: Less.RenderOutput | undefined,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
error: Less.RenderError | undefined,
output: Less.RenderOutput | undefined,
error?: Less.RenderError,
output?: Less.RenderOutput,

importers,
loadPaths: [filePath, 'node_modules', ...(loadPaths ?? [])],
sourceMap: true,
// sourceMapIncludeSources: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// sourceMapIncludeSources: true,

@mrmckeb mrmckeb merged commit fb9d5e8 into main Dec 3, 2022
@mrmckeb mrmckeb deleted the mrmckeb/nov22-updates branch December 3, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants