Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object code generator cleanup #7

Merged
merged 2 commits into from
Apr 25, 2024
Merged

object code generator cleanup #7

merged 2 commits into from
Apr 25, 2024

Conversation

mringler
Copy link
Owner

@mringler mringler commented Dec 1, 2023

fixes some errors when running linters on generated model files:

  • fixed some doctypes
  • removed yoda expressions
  • some cleanup

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: Patch coverage is 97.64706% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.34%. Comparing base (d4ad8c4) to head (aae57b9).
Report is 48 commits behind head on main.

❗ Current head aae57b9 differs from pull request most recent head 6b5d088. Consider uploading reports for the commit 6b5d088 to get more accurate results

Files Patch % Lines
src/Propel/Generator/Builder/Om/ObjectBuilder.php 97.26% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #7      +/-   ##
============================================
- Coverage     89.35%   89.34%   -0.02%     
+ Complexity     8064     8051      -13     
============================================
  Files           232      232              
  Lines         24558    24520      -38     
============================================
- Hits          21945    21908      -37     
+ Misses         2613     2612       -1     
Flag Coverage Δ
5-max 89.34% <97.64%> (-0.02%) ⬇️
7.4 89.34% <97.64%> (-0.02%) ⬇️
agnostic 67.37% <91.76%> (-0.05%) ⬇️
mysql 69.91% <94.11%> (-0.05%) ⬇️
pgsql 69.87% <95.29%> (-0.05%) ⬇️
sqlite 67.83% <94.11%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mringler mringler merged commit b41476d into main Apr 25, 2024
64 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant