Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native peerDependencies to 0.59.9 #1

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

kwokhou
Copy link
Contributor

@kwokhou kwokhou commented Jul 15, 2019

No description provided.

@mribbons
Copy link
Owner

Hi @kwokhou,
Thanks for the PR. Would you be ok with RN "react-native": "^0.59.9"?

This version is required to produce a proper 64 bit version, which is required to meet new play store requirements.

https://android-developers.googleblog.com/2019/01/get-your-apps-ready-for-64-bit.html

facebook/react-native#2814 (comment)

@kwokhou
Copy link
Contributor Author

kwokhou commented Jul 16, 2019

hi @mribbons, Yes. that is fine.

@mribbons
Copy link
Owner

Hi @kwokhou,
Would you kindly mind updating to "react-native": "^0.59.9" and making sure everything compiles, then push to this branch?

I don't have time to test at the moment.

Thanks.

@kwokhou kwokhou changed the title Update react-native peerDependencies to 0.54.2 Update react-native peerDependencies to 0.59.9 Jul 16, 2019
@kwokhou
Copy link
Contributor Author

kwokhou commented Jul 16, 2019

Ok done. I compiled using Android Studio. No error.
android studio

@mribbons
Copy link
Owner

mribbons commented Jul 16, 2019

Thanks @kwokhou just FYI that compiling in Android Studio isn't a good test of changing the peerDependences as it doesn't use package.json.

I have created a fresh react-native project @0.55.9 and confirmed everything works.

Will merge now and push a new npm version soon.

@mribbons mribbons merged commit ba2c97b into mribbons:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants