include Three.Legacy.js contents in bundle outro, not footer #9518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, this feels hacky? Couldn't this be like the other files? (with the required |
|
Yes, you're right, it is a bit – about to send an alternative PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9489 by putting all the legacy stuff inside the bundle. It involves rewriting Three.Legacy.js to reference
exportsrather thanTHREE, and e.g.BoxGeometryrather thanTHREE.BoxGeometry(notexports.BoxGeometrybecause the exports haven't been declared yet – perhaps Rollup should put the outro after the export declaration and not before).