Output encoding #8232
Merged
Output encoding #8232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 26, 2016 08:47
…lors are not encoded and we need to get perfect blends.
bhouston
force-pushed
the
output_encoding
branch
from
8898a86
to
3bd62a1
Compare
|
Looks good! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the previous linear_to_gamma_fragment approach to output encoding with a more flexible system based on texture.encoding with backwards compatibility for WebGLRenderer.gammaOutput = true.
Similar to the previous PR #8117, this PR adds a new injected glsl function
linearToOutputTexelthat encodes output texels based on the encoding specified on the current WebGLRenderTarget, if there is one. This means that this PR supports any of the following output encodings:There is no additional render cost to this PR over the previous approach and it uses no uniforms.
Because background/fog colors in Three.JS currently are not gamma corrected, I have kept this behavior with complex encodings as well. Thus the encoding is applied prior to the fog interpolation, as it was before. This will screw up complex encodings like LovLuv, RGBE, RGBM and RGBD. Maybe I could have a warning in these cases that one shouldn't use fog in those cases. The future solution would be to eventually bring both the background color and fog colors into the encoding, so they are properly encoded like everything else.