Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRManager: Add MSAA support. #30378

Merged
merged 3 commits into from
Jan 22, 2025
Merged

XRManager: Add MSAA support. #30378

merged 3 commits into from
Jan 22, 2025

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 22, 2025

Related issue: #28968

Description

This PR adds MSAA support for the layers code path.

MSAA is implemented with the default code path using renderbuffers which requires an explicit resolve. Support for WEBGL_multisampled_render_to_texture will be added separately.

Copy link

github-actions bot commented Jan 22, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.25
78.28
336.25
78.28
+0 B
+0 B
WebGPU 510.39
141.66
510.54
141.69
+149 B
+32 B
WebGPU Nodes 509.86
141.55
510
141.59
+149 B
+32 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.25
112.13
465.25
112.13
+0 B
+0 B
WebGPU 584.39
158.38
584.54
158.41
+149 B
+29 B
WebGPU Nodes 539.77
147.93
539.92
147.96
+149 B
+29 B

@Mugen87 Mugen87 merged commit 0fb4b68 into mrdoob:dev Jan 22, 2025
12 checks passed
@Mugen87 Mugen87 modified the milestones: r174, r173 Jan 22, 2025
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that it's the MSAA what breaks the lines in these screenshots.

SwiftShader seems to be kind of deprecated though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants