Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Enable dynamic resizing of the cameras array in ArrayCamera #30353

Merged
merged 1 commit into from
Jan 18, 2025
Merged

WebGPURenderer: Enable dynamic resizing of the cameras array in ArrayCamera #30353

merged 1 commit into from
Jan 18, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jan 18, 2025

Related issue: #30346 (comment)

Description

Enable dynamic resizing of the cameras array in ArrayCamera.

@sunag sunag added this to the r173 milestone Jan 18, 2025
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.25
78.28		 336.25
78.28		 +0 B
+0 B
WebGPU 503.18
139.76		 503.38
139.83		 +199 B
+72 B
WebGPU Nodes 502.65
139.65		 502.85
139.72		 +199 B
+72 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.25
112.13		 465.25
112.13		 +0 B
+0 B
WebGPU 576.96
156.41		 577.16
156.46		 +199 B
+58 B
WebGPU Nodes 532.35
145.96		 532.54
146.02		 +199 B
+59 B

@sunag sunag marked this pull request as ready for review January 18, 2025 00:32
@sunag sunag merged commit e4e6f20 into mrdoob:dev Jan 18, 2025
12 checks passed
@sunag sunag deleted the dev-arraycamera-length branch January 18, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r173
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag