Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer: Remove outdated comment. #30306

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Renderer: Remove outdated comment. #30306

merged 1 commit into from
Jan 11, 2025

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 11, 2025

Related issue: -

Description

In the meanwhile, multi materials are supported in Renderer so respective TODO comment in _renderObjects() can be removed.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.52
79.1
339.52
79.1
+0 B
+0 B
WebGPU 490.8
136.38
490.8
136.38
+0 B
+0 B
WebGPU Nodes 490.26
136.27
490.26
136.27
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.41
112.15
465.41
112.15
+0 B
+0 B
WebGPU 561.37
152.09
561.37
152.09
+0 B
+0 B
WebGPU Nodes 516.76
141.66
516.76
141.66
+0 B
+0 B

@sunag sunag added this to the r173 milestone Jan 11, 2025
@sunag sunag merged commit 9c4d85e into mrdoob:dev Jan 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants