Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Improve webgpu_lights_ies_spotlight #30243

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Examples: Improve webgpu_lights_ies_spotlight #30243

merged 2 commits into from
Jan 1, 2025

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Dec 31, 2024

Description

Tried adding a sphere to the example, but I don't think the sphere is being lit up correctly...

Screen.Recording.2024-12-31.at.5.29.50.PM.mov

/cc @sunag

@mrdoob mrdoob added this to the r173 milestone Dec 31, 2024
@sunag
Copy link
Collaborator

sunag commented Jan 1, 2025

I'm testing it on WebGLRenderer, it seems to produce the similar result.
https://jsfiddle.net/Lsjof9cd/1/

so I made some modifications by moving the light target

@sunag sunag changed the title Examples: Added sphere to webgpu_lights_ies_spotlight Examples: Improve webgpu_lights_ies_spotlight Jan 1, 2025
@sunag sunag merged commit 7d72e71 into dev Jan 1, 2025
11 checks passed
@mrdoob mrdoob deleted the ies branch January 1, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants