Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer: Document more modules. #30224

Merged
merged 3 commits into from
Dec 28, 2024
Merged

Renderer: Document more modules. #30224

merged 3 commits into from
Dec 28, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 28, 2024

Related issue: #30182

Description

Documents more modules.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.44
79.06
339.44
79.06
+0 B
+0 B
WebGPU 489.24
135.78
489.09
135.73
-153 B
-59 B
WebGPU Nodes 488.71
135.66
488.55
135.61
-153 B
-47 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11
465.3
112.11
+0 B
+0 B
WebGPU 558.8
151.3
558.64
151.24
-153 B
-53 B
WebGPU Nodes 514.87
141.07
514.72
141.02
-153 B
-54 B

this.isNodeUniformsGroup = true;

}

getNodes() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I have removed this method since it was not used in the code base.

@Mugen87 Mugen87 merged commit 9d4c291 into mrdoob:dev Dec 28, 2024
12 checks passed
@Mugen87 Mugen87 added this to the r172 milestone Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant