Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Disable fog in shadow-material #30204

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 25, 2024

Related issue: #30178

Description

I think it would be to disable the fog in the shadow-map, maybe preserve the fog make more sense for other nodes like OutlineNode or SSAAPass for example. @Mugen87

@sunag sunag added this to the r172 milestone Dec 25, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.44
79.06
339.44
79.06
+0 B
+0 B
WebGPU 488.75
135.61
488.67
135.59
-81 B
-17 B
WebGPU Nodes 488.21
135.49
488.13
135.48
-81 B
-16 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11
465.3
112.11
+0 B
+0 B
WebGPU 558.66
151.23
558.58
151.21
-81 B
-22 B
WebGPU Nodes 514.73
141.01
514.65
140.99
-81 B
-22 B

@sunag sunag marked this pull request as ready for review December 25, 2024 15:14
@sunag sunag merged commit 62b2a82 into mrdoob:dev Dec 26, 2024
12 checks passed
@sunag sunag deleted the dev-renderer-utils branch December 26, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants