New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access of unknown property `offsetNodeNode` in LineDashedNodeMaterial #30175

Merged

Mugen87 merged 1 commit into mrdoob:dev from ycw:fix-linedashednodemat-offset

Dec 20, 2024

Contributor

ycw commented Dec 20, 2024

should be .offsetNode, not .offsetNodeNode


          fix misspelling

a4bedcf

github-actions bot commented Dec 20, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	339.4 79.05	339.4 79.05	+0 B +0 B
WebGPU	487.05 135.09	487.04 135.09	-4 B -3 B
WebGPU Nodes	486.51 134.99	486.51 134.99	-4 B -3 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.3 112.11	465.3 112.11	+0 B +0 B
WebGPU	557.21 150.78	557.21 150.78	-4 B -1 B
WebGPU Nodes	513.28 140.56	513.28 140.56	+0 B +0 B

Mugen87 added this to the r172 milestone

Mugen87 merged commit fbd54d5 into mrdoob:dev

12 checks passed

ycw deleted the fix-linedashednodemat-offset branch

December 20, 2024 14:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet