Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Export shadowWorldPosition #30129

Merged
merged 2 commits into from
Dec 16, 2024
Merged

TSL: Export shadowWorldPosition #30129

merged 2 commits into from
Dec 16, 2024

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Dec 15, 2024

Related issue: N/A

Description

I think this is missing from #30060 in order to export shadowWorldPosition from Three.TSL.js?

I think this is missing from mrdoob#30060?
Copy link

github-actions bot commented Dec 15, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.24
79.02
339.24
79.02
+0 B
+0 B
WebGPU 486.15
134.88
486.17
134.89
+23 B
+10 B
WebGPU Nodes 485.61
134.79
485.63
134.79
+23 B
+9 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.13
112.08
465.13
112.08
+0 B
+0 B
WebGPU 555.32
150.32
555.32
150.32
+0 B
+0 B
WebGPU Nodes 511.24
140.09
511.24
140.09
+0 B
+0 B

@sunag sunag added this to the r172 milestone Dec 16, 2024
@sunag sunag merged commit 6a3b0c8 into mrdoob:dev Dec 16, 2024
12 checks passed
@sunag sunag changed the title Export shadowWorldPosition from TSL TSL: Export shadowWorldPosition Dec 16, 2024
@Methuselah96 Methuselah96 deleted the patch-1 branch December 16, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants