Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line2NodeMaterial: Fix usage of optional nodes. #30107

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

s-rigaud
Copy link
Contributor

@s-rigaud s-rigaud commented Dec 11, 2024

Description

Fix Line2NodeMaterial code using undeclared variables.

Copy link

github-actions bot commented Dec 11, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.21
79.01
339.21
79.01
+0 B
+0 B
WebGPU 486.3
134.97
486.3
134.97
+0 B
+0 B
WebGPU Nodes 485.76
134.87
485.76
134.87
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.06
465.1
112.06
+0 B
+0 B
WebGPU 555.41
150.39
555.41
150.39
+0 B
+0 B
WebGPU Nodes 511.26
140.1
511.26
140.1
+0 B
+0 B

@Mugen87 Mugen87 added this to the r172 milestone Dec 11, 2024
@Mugen87 Mugen87 changed the title Line2NodeMaterial: fix gap Line2NodeMaterial: Fix usage of optional nodes. Dec 11, 2024
@Mugen87 Mugen87 merged commit 3c2c930 into mrdoob:dev Dec 11, 2024
10 of 11 checks passed
@s-rigaud s-rigaud deleted the line2nodematerial-fix-gap branch December 31, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants