Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint: Enforce eqeqeq in addons #30089

Closed
wants to merge 2 commits into from

Conversation

s-rigaud
Copy link
Contributor

Description

I fix most eslint warnings for addons after improving th rules in previous PRs.

I tested all I can on my side especially Arcaball, nothing should be broken as I tried to double check the triple equality when testing against null as undefined == null but undefined !== null.

@s-rigaud s-rigaud changed the title Enforce eqeqeq in addons Eslint: Enforce eqeqeq in addons Dec 10, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 10, 2024

This PR breaks RGBMLoader (I suggest you do not alter the code from the embedded UPNG.js).

TBH, I'm a bit hesitating of making this change since it requires very detailed testing. Especially in modules that use the previous pattern all over the place.

@s-rigaud
Copy link
Contributor Author

Yes I totally understand as no one can really plan all the side effects of those changes. I will just improve the JsDocs to reduce th number of eslint errors and warning in another PR then.

@s-rigaud s-rigaud closed this Dec 10, 2024
@Mugen87 Mugen87 added this to the r172 milestone Dec 10, 2024
@s-rigaud s-rigaud deleted the enforce-eqeqeq-in-addons branch December 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants