Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix Hardware Clipping issues #30083

Conversation

RenaudRohlinger
Copy link
Collaborator

@RenaudRohlinger RenaudRohlinger commented Dec 10, 2024

Related issue: #28237

Description

Clipping in the WebGPURenderer is not working when using vertexNode as setupHardwareClipping is defined in setupPosition. This PR fixes the issue by moving it to setup.
Also this feature highlighted the fact that compileAsync was missing the group argument resulting in an error.

This contribution is funded by Utsubo

Copy link

github-actions bot commented Dec 10, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.21
79.01
339.21
79.01
+0 B
+0 B
WebGPU 485.85
134.89
485.9
134.87
+45 B
-21 B
WebGPU Nodes 485.32
134.79
485.36
134.77
+45 B
-19 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.06
465.1
112.06
+0 B
+0 B
WebGPU 554.96
150.32
555
150.3
+45 B
-19 B
WebGPU Nodes 510.81
140.03
510.86
140.01
+45 B
-17 B

@RenaudRohlinger RenaudRohlinger marked this pull request as draft December 10, 2024 07:04
@RenaudRohlinger RenaudRohlinger marked this pull request as ready for review December 10, 2024 07:53
@RenaudRohlinger RenaudRohlinger changed the title WebGPURenderer: Fix Hardware Clipping with vertexNode WebGPURenderer: Fix Hardware Clipping issues Dec 10, 2024
@RenaudRohlinger RenaudRohlinger added this to the r172 milestone Dec 10, 2024
@RenaudRohlinger RenaudRohlinger merged commit 8ac75e9 into mrdoob:dev Dec 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant