Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint: enforce valid JSdoc format #30076

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

s-rigaud
Copy link
Contributor

@s-rigaud s-rigaud commented Dec 9, 2024

Description

Ensure that functions using JSdoc are properlly documented (no more parameter naming mistake and better editor linting support)

Copy link

github-actions bot commented Dec 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.2
79.01
339.2
79.01
+0 B
+0 B
WebGPU 485.98
134.92
485.98
134.92
+0 B
+0 B
WebGPU Nodes 485.44
134.82
485.44
134.82
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.06
465.1
112.06
+0 B
+0 B
WebGPU 555.38
150.4
555.38
150.4
+0 B
+0 B
WebGPU Nodes 511.23
140.1
511.23
140.1
+0 B
+0 B

@s-rigaud s-rigaud force-pushed the enforce-correct-jsdoc branch 2 times, most recently from d4e976f to fdb317c Compare December 9, 2024 16:13
@Mugen87 Mugen87 merged commit fa8e6a1 into mrdoob:dev Dec 9, 2024
12 checks passed
@Mugen87 Mugen87 added this to the r172 milestone Dec 9, 2024
@s-rigaud s-rigaud deleted the enforce-correct-jsdoc branch December 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants