Docs: Fix code blocks occasionally lacking white-space in Firefox #30036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #30008
Description
Prettify strips white-space from code blocks unless they are preformatted. This is based on the element's computed style. While the page is loading, the iframe is hidden using
display: none, which under Firefox meansgetComputedStylereturns empty results. Depending on load order and connection speed, this could cause prettify to incorrectly assume code blocks aren't preformatted.This PR sets the
currentStyleproperty on the code block elements before loadingprettify.js. This triggers a code path that avoidsgetComputedStyleworking around the issue. The code path is originally for old versions of IE.This contribution is funded by Fern Solutions