WebGPURenderer: Add SpotLight.map support
#29989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
cmhhelgeson
pushed a commit
to cmhhelgeson/three.js
that referenced
this pull request
Dec 5, 2024
* SpotLight: Add `.map` support * cleanup
Closed
sunag
added a commit
to sunag/three.js
that referenced
this pull request
Dec 7, 2024
This reverts commit e2e04d3.
sunag
added a commit
to sunag/three.js
that referenced
this pull request
Dec 7, 2024
This reverts commit 9a2e6c2.
sunag
added a commit
that referenced
this pull request
Dec 7, 2024
* fix getNodeType() * Revert "WebGPURenderer: Shadow fixes (#29991)" This reverts commit f91fbc3. * Revert "WebGPURenderer: Add `SpotLight.map` support (#29989)" This reverts commit e2e04d3. * cleanup * Reapply "WebGPURenderer: Add `SpotLight.map` support (#29989)" This reverts commit 9a2e6c2. * Reapply "WebGPURenderer: Shadow fixes (#29991)" This reverts commit 50c6e14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29942
Description
Add
SpotLight.mapsupport forWebGPURenderer. UnlikeWebGLRenderer, turning on.castShadowshould be optional.SpotLight.mapsupport.Light.colorNodeoptional usagelightShadowMatrix( light ),lightProjectionUV( light )WebGLRenderer:
