Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WGSLNodeBuilder: Fix generateWrapFunction() cache includes #29846

Merged
merged 1 commit into from
Nov 8, 2024
Merged

WGSLNodeBuilder: Fix generateWrapFunction() cache includes #29846

merged 1 commit into from
Nov 8, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 8, 2024

Related issue: #29828

Description

Fix generateWrapFunction() cache includes.

@sunag sunag added this to the r171 milestone Nov 8, 2024
@sunag sunag marked this pull request as ready for review November 8, 2024 15:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.22
79.04		 339.22
79.04		 +0 B
+0 B
WebGPU 476.91
132.18		 476.9
132.19		 -5 B
+6 B
WebGPU Nodes 476.2
132.01		 476.2
132.01		 -5 B
+5 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.67
111.99		 464.67
111.99		 +0 B
+0 B
WebGPU 545.94
147.85		 545.93
147.86		 -5 B
+4 B
WebGPU Nodes 501.82
137.55		 501.81
137.56		 -5 B
+6 B

@sunag sunag merged commit d35544a into mrdoob:dev Nov 8, 2024
12 checks passed
@sunag sunag deleted the dev-fix-includes branch November 8, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r171
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag