Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgressiveLightMap: Remove usage of THREE namespace. #29747

Merged
merged 2 commits into from
Oct 25, 2024
Merged

ProgressiveLightMap: Remove usage of THREE namespace. #29747

merged 2 commits into from
Oct 25, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 25, 2024

Related issue: -

Description

The PR remove usage of THREE namespace in ProgressiveLightMap.

@Mugen87 Mugen87 added this to the r170 milestone Oct 25, 2024
@Mugen87 Mugen87 merged commit 1978cad into mrdoob:dev Oct 25, 2024
11 checks passed
@linbingquan
Copy link
Contributor

linbingquan commented Oct 25, 2024 •
edited by Mugen87
Loading

These files also have import * as THREE from 'three'.

examples\jsm\offscreen\scene.js
examples\jsm\transpiler\TSLEncoder.js
examples\jsm\tsl\lighting\TiledLightsNode.js
examples\jsm\webxr\OculusHandPointerModel.js
examples\jsm\webxr\Text2D.js

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Oct 25, 2024

@linbingquan Would you like to file a PR and remove the remaining * imports (except for examples\jsm\offscreen\scene.js)?

@linbingquan
Copy link
Contributor

examples\jsm\transpiler\TSLEncoder.js should be not remove, because of TSLEncoder.addImport.

@linbingquan linbingquan mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r170
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @linbingquan