Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGSLNodeFunction: Ignore convertion of unknown types #29724

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 22, 2024

Related issue: #29720

Description

Ignore convertion of unknown types.

@sunag sunag marked this pull request as ready for review October 22, 2024 15:22
@sunag sunag added this to the r170 milestone Oct 22, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 692.88
171.51
692.88
171.51
+0 B
+0 B
WebGPU 818.62
220.76
818.62
220.76
-1 B
+0 B
WebGPU Nodes 818.13
220.62
818.13
220.62
-1 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.09
112.28
465.09
112.28
+0 B
+0 B
WebGPU 539.55
145.72
539.55
145.72
-1 B
+0 B
WebGPU Nodes 495.55
135.53
495.55
135.53
-1 B
+0 B

@sunag sunag merged commit 226c32c into mrdoob:dev Oct 22, 2024
12 checks passed
@sunag sunag deleted the dev-wgsl-types branch October 22, 2024 15:48
@Spiri0
Copy link
Contributor

Spiri0 commented Oct 24, 2024

I tried to install an extension for vec4 but I have to look at it again because something is wrong: #29739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants