-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BatchedMesh: Consolidate internal geometry information #29687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
gkjohnson
changed the title
BatchedMesh: Batched class cleanup
BatchedMesh: Consolidate internal geometry information
Oct 18, 2024
Mugen87
approved these changes
Oct 18, 2024
This was referenced Oct 19, 2024
This was referenced Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29624, #29603
Description
Clean up for the BatchedMesh class to make things a little bit more clear and easier to manage:
_bounds
,_reservedRanges
, and_drawRanges
into a common_geometryInfo
member.(removed the following changes to reduce noise in the change set, will re-add them in a followup)
Remove some unnecessary global fieldsRename "drawInfo" to "instanceInfo" for clarity- Expose information about instance count, unused vertex & index count so applications can make decisions about whether geometries can be added.Once the class is finished and cleaned up I'll make an issue to discuss how we should move forward with the BatchedMesh implementation.