Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: Fixes and improvements for reflector and gaussianBlur #29619

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 11, 2024

Related issue: #29606 (comment)

Description

Maybe the sequential fix show others issue that I don't detected yet.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.92
170.93
689.92
170.93
+0 B
+0 B
WebGPU 813.52
219.09
814.17
219.22
+652 B
+125 B
WebGPU Nodes 813.03
218.94
813.68
219.06
+652 B
+116 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.94
111.81
462.94
111.81
+0 B
+0 B
WebGPU 537.35
145
537.52
145.03
+172 B
+36 B
WebGPU Nodes 493.46
134.72
493.64
134.76
+172 B
+39 B

@sunag sunag marked this pull request as ready for review October 11, 2024 14:41
@sunag sunag merged commit 0e584a2 into mrdoob:dev Oct 11, 2024
12 checks passed
@sunag sunag deleted the dev-blur-fixes branch October 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant