Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Add Support for Renderer Without Depth and Stencil Buffers #29533

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

Description

Fixes the issue where initializing WebGPURenderer with depth: false was not functioning. This PR enables support for renderers without a depth-stencil buffer in both the WebGPU and WebGL backends.

This contribution is funded by Utsubo

Copy link

github-actions bot commented Sep 30, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 687.47
170.27
687.47
170.27
+0 B
+0 B
WebGPU 806.21
217.08
806.46
217.18
+257 B
+103 B
WebGPU Nodes 805.71
216.94
805.97
217.05
+257 B
+104 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.85
111.79
462.85
111.79
+0 B
+0 B
WebGPU 535.66
144.58
535.92
144.69
+257 B
+109 B
WebGPU Nodes 491.75
134.31
492
134.42
+257 B
+108 B

@RenaudRohlinger RenaudRohlinger added this to the r170 milestone Sep 30, 2024
@sunag sunag merged commit d4ae99c into mrdoob:dev Sep 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants